pascal_nulah/Nulah.PowerShell
pascal_nulah/Nulah.PowerShell
Watch
1
0
Fork
You've already forked Nulah.PowerShell
 0
Code Issues 12 Pull requests Projects 2 Releases 1 Activity Actions

feat: Add GitRepoRegistration cmdlets #5

Merged
pascal_nulah merged 69 commits from feature/git-provider into dev 2026-09-06 09:33:36 +10:00
Conversation 5 Commits 69 Files changed 66 +3 -3
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit cece927b3f - Show all commits

chore: Add known ticket issues to TODOs

Prev Next
Scott 2026-09-06 08:47:16 +10:00
commit cece927b3f

4
build/Tasks/CopyOutputTask.cs
View file

@ -15,8 +15,8 @@ public class CopyOutputTask : FrostingTask<BuildContext>
public override void Run(BuildContext context)
{
var powershellModuleName = "PowershellModule";
// TODO: probably don't create full file locations when I can pass the output dir in and have the script
// make the path
// TODO: [#10] Refactor file paths used in build project to be more explict and easier to understand
// Probably don't create full file locations when I can pass the output dir in and have the script make the path
var scriptParams = new
{
PowershellModuleFileLocation = $"{context.PowershellModuleOutputDir}/{powershellModuleName}.psd1",

2
tests/ModuleTests/Git/AddRegistrationTests.cs
View file

@ -1,10 +1,10 @@
using System.Text;
using ModuleCore.Calendar;
using ModuleCore.Git;
using ModuleTests.Git.TestData;
namespace ModuleTests.Git;
// TODO: [#12] GitRepoRegistration tests should reset database at start of each test
public class AddRegistrationTests
pascal_nulah marked this conversation as resolved
pascal_nulah commented 2026-09-05 13:49:51 +10:00
Copy link

todo: All of the tests in this suite should be wrapped in a try .. finally with the finally block calling DeleteDatabase so test databases don't linger around.

Alternatively (or in addition to), each test should attempt to rest any previously existing database with a ResetDatabase() method for instances where a test is run in debug with breakpoints and a dev hits stop instead of letting the test fail (which will result in the finally block never being called)

todo: All of the tests in this suite should be wrapped in a `try .. finally` with the finally block calling `DeleteDatabase` so test databases don't linger around. Alternatively (or in addition to), each test should attempt to rest any previously existing database with a `ResetDatabase()` method for instances where a test is run in debug with breakpoints and a dev hits stop instead of letting the test fail (which will result in the `finally` block never being called)
pascal_nulah commented 2026-09-06 09:16:37 +10:00
Copy link

GitRepoRegistration tests should reset database at start of each test #12

[GitRepoRegistration tests should reset database at start of each test #12](https://moar.ws/git/pascal_nulah/Nulah.PowerShell/issues/12)
{
private static readonly VerifySettings Settings;