fix(git-tests): Create per-test specific databases

src/ModuleCore/Database/DatabaseManager.cs

@@ -51,6 +51,18 @@ public class DatabaseManager
 		return exists ?? false;
 	}
 
+	/// <summary>
+	/// Deletes the current database file. This will cause any future instance methods to fail on database action if
+	/// a new instance is not created.
+	/// <para>
+	/// This method should be avoided unless calling from a test.
+	/// </para>
+	/// </summary>
+	internal void DeleteDatabase()
+	{
+		_databaseLocation.Delete();
+	}
+
 	/// <summary>
 	/// Removes double dots from the filename and removes the file extension
 	/// </summary>

src/ModuleCore/Git/GitManager.cs

@@ -17,6 +17,8 @@ public class GitManager
 	private GitManager(string? databaseName = null)
 	{
 		_registrations = new ConcurrentDictionary<string, InternalGitRegistration>();
+		// Regular usage of this constructor will never pass a database name in. Currently only tests should be hitting
+		// a code path that has a different database name
 		_db = new DatabaseManager(databaseName ?? "git.db");
 
 		InitialiseRegistrations();
@@ -29,6 +31,14 @@ public class GitManager
 	/// </summary>
 	internal static GitManager InternalFreshInstance(string databaseName) => new(databaseName);
 
+	/// <summary>
+	/// Deletes the underlying database file.
+	/// <para>
+	///	Avoid calling this outside of tests.
+	/// </para>
+	/// </summary>
+	internal void DeleteDatabase() => _db.DeleteDatabase();
+
 	/// <summary>
 	/// Creates up any database tables and loads all previously saved git registrations.
 	/// </summary>

tests/ModuleTests/Git/AddRegistrationTests.cs

@@ -24,13 +24,15 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName($"{nameof(BasicRepoRegistration)}_{testData.testId}");
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(BasicRepoRegistration));
 
 		var repoRegistration = gitManager.RegisterRepo("Test:/some/test/repo", testData.path);
 		var sb = new StringBuilder();
 		sb.AppendLine($"Attempted to register: {testData.path}")
 			.AppendLine($"Registration result: {repoRegistration}");
 
+		gitManager.DeleteDatabase();
+
 		return Verify(sb, Settings);
 	}
 
@@ -39,11 +41,13 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName(nameof(RepoRegistrationWithEmptyName));
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(RepoRegistrationWithEmptyName));
 		var testRepoAbsolutePath = "Test:/some/test/repo";
 
 		var emptyName = gitManager.RegisterRepo(testRepoAbsolutePath, "");
 
+		gitManager.DeleteDatabase();
+
 		Assert.Equal("repo", emptyName);
 	}
 
@@ -52,13 +56,15 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName(nameof(RepoRegistrationWithNullName));
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(RepoRegistrationWithNullName));
 		var testRepoAbsolutePath = "Test:/some/test/repo";
 
 		// Name is technically not-nullable, but string is a reference type so null can be passed in so we should test
 		// it regardless
 		var nullName = gitManager.RegisterRepo(testRepoAbsolutePath, null!);
 
+		gitManager.DeleteDatabase();
+
 		Assert.Equal("repo", nullName);
 	}
 
@@ -67,11 +73,13 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName(nameof(RepoRegistrationWithWhitespaceName));
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(RepoRegistrationWithWhitespaceName));
 		var testRepoAbsolutePath = "Test:/some/test/repo";
 
 		var whitespaceName = gitManager.RegisterRepo(testRepoAbsolutePath, "            ");
 
+		gitManager.DeleteDatabase();
+
 		Assert.Equal("repo", whitespaceName);
 	}
 
@@ -80,7 +88,7 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName(nameof(RepoRegistrationWithWhitespaceName));
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(RepoRegistrationWithWhitespaceName));
 		var testRepoAbsolutePath = "Test:/some/test/repo";
 		string[] paths = ["test", "nested", "path"];
 		var names = (NormalSeparator: string.Join(Path.DirectorySeparatorChar, paths), AltSeparator: string.Join(Path.AltDirectorySeparatorChar, paths));
@@ -93,6 +101,8 @@ public class AddRegistrationTests
 		Assert.Equal(Path.Combine(paths[..1]), secondRegistration);
 
 		Assert.Throws<Exception>(() => gitManager.RegisterRepo(testRepoAbsolutePath, Path.Combine(paths[..1])));
+
+		gitManager.DeleteDatabase();
 	}
 
 	[Fact]
@@ -100,7 +110,7 @@ public class AddRegistrationTests
 	{
 		Settings.UseFileName(nameof(RepoRegistrationWithWhitespaceName));
 
-		var gitManager = GitManager.InternalFreshInstance;
+		var gitManager = GitManager.InternalFreshInstance(nameof(RepoRegistrationWithWhitespaceName));
 		var testRepoAbsolutePath = "Test:/some/test/repo";
 		string[] paths = ["test", "nested", "path"];
 		var names = (NormalSeparator: string.Join(Path.DirectorySeparatorChar, paths), AltSeparator: string.Join(Path.AltDirectorySeparatorChar, paths));
@@ -110,6 +120,8 @@ public class AddRegistrationTests
 		var secondRegistration = gitManager.RegisterRepo(testRepoAbsolutePath, Path.Combine(paths[..1]));
 		var differentPathSeparatorRegistration = gitManager.RegisterRepo(testRepoAbsolutePath, names.AltSeparator);
 
+		gitManager.DeleteDatabase();
+
 		Assert.Equal(Path.Combine(paths), firstRegistration);
 		Assert.Equal(Path.Combine(paths[..1]), secondRegistration);
 		Assert.Equal(names.AltSeparator, differentPathSeparatorRegistration);